V2-V1 comparison checks use non-existent V2 result property#2536
Merged
Conversation
nikhilwoodruff
force-pushed
the
nikhilwoodruff/issue2535
branch
from
8be1725 to
36200c2
Compare
anth-volk
approved these changes
Jun 3, 2025
Collaborator
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
LGTM! Thanks for super quick fix @nikhilwoodruff.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
- Coverage 63.62% 63.56% -0.06%
==========================================
Files 56 56
Lines 2161 2163 +2
Branches 287 287
==========================================
Hits 1375 1375
- Misses 729 731 +2
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2535